Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batteryarc] Add support for reading multiple batteries in one batteryarc instance #419

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ZachIndigo
Copy link

@ZachIndigo ZachIndigo commented Oct 19, 2023

For multiple batteries, each percentage gets added into "charge", and then divided by the number of batteries. Batteries with status "Unknown" don't get counted.

This way you can have a rough overall power indicator (it perhaps could be improved by reading the total capacity of each battery and mathing the actual percentage out of that, but that seems overkill).

I could make it a separate widget, or make it require a flag, if that would be preferable (this could be added to the other pull request about passing an id for which battery for the widget to read, in which case you could pass some other standard number like -1 for every battery).

For multiple batteries, each percentage gets added into "charge", and
then divided by the number of batteries. Batteries with status "Unknown"
don't get counted.
zachir added 2 commits November 18, 2023 14:50
Add in reset_garbage_collector variable as a hack fix for a memory leak
caused when memory is allocated for certain widgets faster than it is
consumed (by triggering the garbage collector frequently).
Default to beautiful.font, and use 'Play 9' as a backup.
if (reset_garbage_collector > 10) then
collectgarbage()
reset_garbage_collector = 0
end
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain how does this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants